Ethan Quach wrote: > > > Tim Knitter wrote: >> Ethan Quach wrote: >> >>> Tim, >>> >>> be_create.c >>> --------------- >>> 1385 - why is this changed to BE_ERR_SS_EXISTS ? >>> a failure from be_get_snap() does not signify a snapshot exists. >>> >>> >> >> That should have been BE_ERR_SS_NOENT, signifying that the snapshot >> doesn't exist since be_get_snap() failed to parse it. >> > > This failure here is when we're unable to parse out the snapshot name > portion (the part after the @ ) from the origin dataset name returned by > ZFS, presumably because the origin dataset name is malformed. So I
One would think that zfs wouldn't let a snapshot name become malformed upon creation so BE_ERR_ZFS doesn't seem quite right either. > think it either needs to be changed back to BE_ERR_ZFS, or perhaps > BE_ERR_INVAL. BE_ERR_INVAL seems better since if be_get_snap() fails the "parent" parameter passed in probably contains a character be_get_snap() doesn't expect. So I'll go with that. > > Printing out the presumed unparsable origin dataset name in the debug > line above it might be useful as well: > > - "get snapshot name from origin\n")); > + "get snapshot name from origin %s\n), origin); > Yeah I'll add that too. Thanks Tim > > thanks, > -ethan > >> I'll change it. >> >> Tim >> >> >>> -ethan >>> >>> >>> >>> >>> Tim Knitter wrote: >>> >>>> Thanks to all for reviewing the snap2 webrev. >>>> >>>> Please review my changes based on the comments I addressed from >>>> Evan, Ethan and Joe. >>>> >>>> http://cr.opensolaris.org/~tsk/codeReviewCommentsSnap2/ >>>> >>>> Thanks >>>> Tim >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>
