Hi Joe,
Joseph J VLcek wrote: > Jan, > > Sorry I didn't pick up on this initially but > usr/src/lib/libict/ict_test.c needs to be updated to include > ict_mark_root_pool_ready No problem at all - I did modified TI test driver but forgot about ICT one :-) > > In an effort to help overcome my oversight I have made the edits to > ict_test.c and attached it. I have not compiled or tested it which > requires your other changes... Thank you very much ! I picked up your version of ICT test driver, compiled it and tested - everything works like a charm. > > Hope this helps and abain I'm very sorry I missed this issue. It definitely helped ! > > On the positive note everything else looks good. Thanks a lot for your help ! Jan > > Joe > > jan damborsky wrote: >> Hi Joe, >> >> thank you very much for code review. >> I incorporated all your comments and retested with ISO >> based on build 99 (SUNWbeadm manually added to the image >> in order to workaround bug 3810). The same set of tests >> was carried out. >> >> In anybody interested, the iso&usb can be obtained from >> following location (available only internally): >> >> $ ls -l /net/10.18.138.30/rpool/slim_1771_99/media/ >> total 3122970 >> -rw-r--r-- 1 root root 769206272 Oct 16 00:47 OpenSolaris.iso >> -r--r--r-- 1 root root 923047424 Oct 16 00:54 OpenSolaris.usb >> >> Joe and (Dave and/or Sanjay), >> could I please you to take a look at the updated webrev ? >> >> http://cr.opensolaris.org/~dambi/bug-1771-cr/ >> >> Thank you very much, >> Jan >> >> >> Joseph J VLcek wrote: >>> jan damborsky wrote: >>>> Hi all, >>>> >>>> could I please ask for reviewing the fix for following CR (blocker >>>> for 2008.11) ? >>>> >>>> 1771 Installer can't be restarted if it already created ZFS root pool >>>> >>>> * bug >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1771 >>>> >>>> * Webrev: >>>> http://cr.opensolaris.org/~dambi/bug-1771/ >>>> >>>> >>>> Thank you very much, >>>> Jan >>>> >>>> >>>> The modules affected and tested: >>>> * libti, liborchestrator, libict >>>> >>>> test conditions: >>>> * platform: >>>> - vmWare (800 MiB RWM for guest OS) on W2110Z (2GiB RWM) >>>> - Ultra 20 (1GiB RWM) >>>> >>>> * ISO: OpenSolaris based on build 98 created using Distro >>>> Constructor taking advantage of checkpointing feature >>>> >>>> tests carried out: >>>> >>>> [1] Regression tests >>>> * fresh installation on minimum disk size (without swap) >>>> * fresh installation on minimum disk size (with swap) >>>> * fresh installation on recommended disk size >>>> >>>> [2] Test of new functionality >>>> * restart of interrupted fresh installation on recommended disk size >>>> - swap and dump created >>>> - process interrupted during transfer phase >>>> - when restarted, installer successfully released >>>> dump and swap ZFS volumes, ZFS pool was destroyed, >>>> installation finished successfully >>>> >>>> * restart of finished fresh installation on recommended disk size >>>> - swap and dump created >>>> - installation process finished successfully >>>> - when restarted after successful installation, installer >>>> refused to destroy the ZFS pool >>>> >>>> * attempt to run installer, when 'rpool' exists, but not marked 'busy' >>>> - ZFS pool 'rpool' manually created (not marked 'busy') >>>> - installer refused to destroy existing ZFS pool >>>> >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> >>> Jan, >>> >>> This looks good. I see two possible issues described below. >>> >>> Joe >>> >>> >>> >>> usr/src/lib/libti/test_ti.c 43 lines changed: >>> +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-= >>> >>> >>> >>> Allowing both upper and lower case P for target_type pool >>> create/release >>> could be confusing. Perhaps a clearer description in the usage would >>> help. >>> >>> >>> usr/src/lib/libti/ti_api.h 15 lines changed: >>> +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-= >>> >>> >>> >>> 87 #define RPOOL_PROPERTY_STATE "org.opensolaris.caiman:install" >>> 88 #define RPOOL_BUSY "busy" >>> 89 #define RPOOL_READY "ready" >>> 90 >>> 91 /* >>> 92 * ZFS volume names for swap and dump >>> 93 */ >>> 94 #define ZFS_VOL_NAME_SWAP "swap" >>> 95 #define ZFS_VOL_NAME_DUMP "dump" >>> >>> Shouldn't these have the TI_ prefix? >>> >>> >> >
