Hi Sanjay, Sanjay Nadkarni wrote: > ict_test.c: > 217: I noticed that strncmp has a number instead of strlen. Since > this is not a performance issue and it would be safer to do > strlen(MARK_ROOT_POOL_READY). > > It would probably make sense to do this for all the other printf.
You are right. Do you think it is fine if I file new bug in order to address this ? Thank you very much for looking at this, Jan > > -Sanjay > > > jan damborsky wrote: >> Dave Miner wrote: >> >>> jan damborsky wrote: >>> >>>> Hi Joe, >>>> >>>> thank you very much for code review. >>>> I incorporated all your comments and retested with ISO >>>> based on build 99 (SUNWbeadm manually added to the image >>>> in order to workaround bug 3810). The same set of tests >>>> was carried out. >>>> >>>> In anybody interested, the iso&usb can be obtained from >>>> following location (available only internally): >>>> >>>> $ ls -l /net/10.18.138.30/rpool/slim_1771_99/media/ >>>> total 3122970 >>>> -rw-r--r-- 1 root root 769206272 Oct 16 00:47 >>>> OpenSolaris.iso >>>> -r--r--r-- 1 root root 923047424 Oct 16 00:54 >>>> OpenSolaris.usb >>>> >>>> Joe and (Dave and/or Sanjay), >>>> could I please you to take a look at the updated webrev ? >>>> >>>> http://cr.opensolaris.org/~dambi/bug-1771-cr/ >>>> >>>> >>> Quite clean. Fine with me. >>> >> >> Dave, >> >> thank you very much for reviewing those changes ! >> >> Jan >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
