Jean McCormack wrote: > This addresses bug 4005 DC manifests should have comments about the > different fields > > CR: > http://defect.opensolaris.org/bz/show_bug.cgi?id=4005 > > Webrev: > > http://cr.opensolaris.org/~jeanm/slim_4005/ > > Jean > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > Hi Jean,
Here are my comments. The line numbers are from the slim_cd.xml file, but I think they apply to both files. - The comment about "stop_on_error". Would we also use stop_on_error for other things besides IPS and finalizer script errors? I am using it in my bug fix (not putback yet) to stop when we can't register finalizer scripts. So, can we change the comment for stop_on_error to stay that this for stopping when any error occurs while DC is running? - Line 112-115, we should also mention that the list of files/dirs specified in the list must exist in the pkg image area. - Line 200-202: actually this is the compression type used for the pkg.zlib and misc.zlib. The compression type for the usr.zlib is specified as an argument to the /usr/share/distro_const/post_bootroot_pkg_image_mod script. Also, our scripts currently don't use the value for compression level. So, we should not mention it here, because if they specify something, it will be ignored. - line 204-206: Can we add something here that says if the build area is not a ZFS dataset or mountpoint, checkpointing will not be enabled? Thanks, --Karen
