Evan,
be_list.c
---------
172 - When is cb.be_node instantiated as a be_node_list_t structure
when no pools are found? I think this would be safer if you checked
for "if (cb.be_nodes == NULL)" here instead. You can do this if you
initialize cb at line 140 to "cb = { 0 };" I think.
174-175 - "be_name" argument not needed. The message could
probably be simplified? "No BEs found\n"
Otherwise, everything else looks okay.
(are you integrating 1002 as well? If so needs to be marked a
blocker)
thanks,
-ethan
Evan Layton wrote:
> I need a code review for:
>
> http://cr.opensolaris.org/~evanl/snap_1012/
>
> This webrev includes the fixes for 1002 and 1012
>
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1002
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1012
>
> Thanks!
> -evan
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
