Ethan Quach wrote:
> Evan,
>
> be_list.c
> ---------
> 172 - When is cb.be_node instantiated as a be_node_list_t structure
> when no pools are found? I think this would be safer if you checked
> for "if (cb.be_nodes == NULL)" here instead. You can do this if you
> initialize cb at line 140 to "cb = { 0 };" I think.
The problem with doing that is that cb.be_nodes will have a valid address
in it because cb.be_nodes is set to bes_found which is allocated on line
147. The problem with what I've done here is that it was supposed to be
an "else if" not an just an "if". The block of code below should be the same.
>
> 174-175 - "be_name" argument not needed. The message could
> probably be simplified? "No BEs found\n"
fixed.
>
> Otherwise, everything else looks okay.
>
> (are you integrating 1002 as well? If so needs to be marked a
> blocker)
Yes marked as such now.
Thanks for the comments!
-evan
>
> thanks,
> -ethan
>
>
> Evan Layton wrote:
>> I need a code review for:
>>
>> http://cr.opensolaris.org/~evanl/snap_1012/
>>
>> This webrev includes the fixes for 1002 and 1012
>>
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1002
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1012
>>
>> Thanks!
>> -evan
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
