Hi Sarah, Thank you very much for code review.
Please see my response below. Jan Sarah Jelinek wrote: > Hi Jan, > > The code looks fine. A couple of things: > > -Can you please update the bug with the data we have been discussing > regarding the limitations of this fix and what will and won't be > localized? Done. > -Also, please provide a list of the pages you saw in the installer > that are apparently not localized. We need to get L10n folks to get > this done. I have tried es_ES.UTF-8 locale and noticed following things are not localized. * Open Solaris License window displayed right after desktop comes up. Installer ----------- * icon on desktop * Disk screen - "Partition the disk" * Time Zone, Date and Time screen - cities on map * Locale screen - "Set the default language support and locale specific data formats" - "Language" - "No default language support" - "Locale" * Installation screen - All progress bar messages There might be more after installer finishes, but it failed on 95% due to the known issue. Since I am not sure that set of not localized messages is the same for other locales, should I check also for rest of the languages ? > > Regards, > sarah > **** > > jan damborsky wrote: >> Hi Sarah, >> >> could I please ask you to review changes for >> following bug? >> >> 973 - UI for language selection should be invoked during boot process >> http://defect.opensolaris.org/bz/show_bug.cgi?id=973 >> >> Webrev is available at >> http://cr.opensolaris.org/~dambi/973/webrev >> >> Thank you very much, >> Jan >> >> >>
