Hi Jan, I have a couple of questions:
-I assume we are exporting the 'rpool' pool if found because we cannot reliably determine which target that pool exists on, and we don't want to hork the users existing data? -We only log the message that we have done this, but how would the user know otherwise that their existing root pool, which may have been on a completely different target, has been exported. -we should consider a way to notify the user more forcefully that we have actually done this. It seems unexpected, in particular when it is on a different target than the one we are installing to. The code looks ok. thanks, sarah **** Jan Damborsky wrote: > Hi Sarah, Dave, > > could I please ask you to review changes for > following bug? > > 1013 - TI shouldn't destroy 'rpool' on other than target disk > http://defect.opensolaris.org/bz/show_bug.cgi?id=1013 > > Webrev is available at > http://cr.opensolaris.org/~dambi/bug-1013 > > Thank you very much, > Jan > > >
