Hi Dave,
Dave Miner wrote: > Jan Damborsky wrote: >> Hi Sarah, Dave, >> >> could I please ask you to review changes for >> following bug? >> >> 1013 - TI shouldn't destroy 'rpool' on other than target disk >> http://defect.opensolaris.org/bz/show_bug.cgi?id=1013 >> >> Webrev is available at >> http://cr.opensolaris.org/~dambi/bug-1013 >> > > One thing that occurred to me which you need to test is whether a root > pool that ends up being exported from the block at 488 will still boot > after the export. I seem to recall there being a problem with booting a > pool that was left exported. You are right - when pool is exported, it is no longer bootable. When it is then imported, it can be booted again. Since we are not able to export without loosing the ability to boot, should we then just let user know that pool already exists and installation can't proceed ? > > Would you file a bug about the issue with install-finish so that we can > sort this out? Really, what's here almost looks like an install-finish > function. Done. 1040 - postinstallation tasks should be moved to install-finish script http://defect.opensolaris.org/bz/show_bug.cgi?id=1040 Thank you very much for looking at this, Jan
