Ok, if you are confident that the LD_LIBRARY_PATH will not pollute the 
other commands in the script, I think the change is fine.

Channing

Dave Miner wrote:
> Channing Lovely wrote:
>> Hi Dave,
>>
>> since you are modifying LD_LIBRARY_PATH on lines 422 and 443 of 
>> build_dist.lib, shouldn't those commands be run in a subshell?
>>
>> ie:
>>
>> (
>> LD_LIBRARY_PATH=$DIST_PROTO/usr/lib
>>
>> time ${DIST_PROTO}/usr/sbin/lofiadm -C lzma `pwd`/solaris.zlib
>>
>> )
>>
>
> I don't see why; the form I'm using should make the setting effective 
> only for the environment of the command being invoked.
>
> Dave
>
>>
>>
>> Channing
>>
>> Dave Miner wrote:
>>> Please review
>>>
>>> http://cr.opensolaris.org/~dminer/dc_1038/
>>>
>>> which addresses
>>>
>>> 1038 Missing /var/cache in root archive causes slow desktop start on 
>>> live CD
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1038
>>>
>>> Thanks,
>>> Dave
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>   
>>
>


Reply via email to