Jean McCormack wrote: > Addresses: > http://defect.opensolaris.org/bz/show_bug.cgi?id=1125 > > Webrev: > http://cr.opensolaris.org/~jeanm/distro_constructor/ >
A couple of things: - It would be nice if this also allowed gzip-9, since lofiadm allows that to be used as well - Relatedly, I'd rather we didn't duplicate lofiadm's error checking of its command-line parameters, since this creates another place that needs changing if and when lofiadm acquires additional compression. You could pass this through to a dummy lofiadm invocation to let it validate, perhaps. Dave
