Channing Lovely wrote:
> As I said before, I am fine with your code changes. I am pretty sure 
> that introducing some weird checking into the DC code is probably not 
> the way to go. However, we need to do something. The DC page on 
> opensolaris.org says
> 
> In order to use the Distribution Constructor, you must have installed 
> Solaris Nevada build 71 or a later build on your system.
> 
> and that is clearly not true anymore. The SXDE 1/08 won't work (based on 
> 79b) for several reasons, and preview 2 will probably fail due to the 
> SUNWclofi issue. I think the main page on opensolaris.org needs to be 
> updated, and there should be a bug against the man page for lofiadm.

You have the rights to modify the opensolaris page, so use them if you 
see something that isn't right.

I suggest these choices:

- Eliminate the validation of this parameter, let it fail if it's wrong 
when that point in the build is reached
- Only issue a warning if Jean's proposed validation fails
- Require that the build system have a version of lofiadm which supports 
the compression we want (potentially at a configurable path); in which 
case, we'd use that one to build and not the one we install in the proto 
area.

Jean, your testing is suspect here: lines 113 and 114  in build_dist.lib 
don't agree on what path is being used.

Dave


Reply via email to