Dave Miner wrote: > Sarah Jelinek wrote: >> Hi Dave, >> >> Thanks for the review. Comments inline... >> > > And thanks for your responses, I'll look forward to the updated doc that > reflects them. Only one I thought I'd follow up on: > ... >>> om_getAvailableLocales: See earlier comments about specifying >>> application behavior, but why would a null list of locales be fatal? >>> "C" always works, and there seems no harm in proceeding in that case >>> so long as the user's happy. >>> >> >> Well... we assumed if there were no locales on the media the media was >> likely corrupt. So, that is why it is listed as fatal. >> > > For this particular project I suppose it doesn't really matter much as > your assumption is probably correct for all the usages you'll have. For > the future, in cases where developers are building their own images for > testing or other purposes, they may well not have (or want to have) any > other locales available, so in that sense I don't think this particular > assumption would hold.
That's a very good point, something I hadn't thought of. I think what we need to do is return a NULL list, and allow the install application decide what to do with that data. sarah **** > > Dave > >>
