Niall Power wrote: >>>> om_getDiskPartitionInfo: why not just take a DiskInfo as the first >>>> argument? And what is meant by "A failure will be fatal in this case"? >>> The DiskInfo structure returned from om_getDiskInfo is a linked list of >>> DiskInfo. Why the whole structure needs to be passed back when diskName >>> is enough to get the partitions. >>> > >> If this were the long-term design I'd be pushing strongly to have the >> callers not directly referencing structure members but instead using >> accessor functions, because that gives us much more flexibility in >> evolving the design, so generally I'm suggesting that callers not have >> to grovel around in the structures to use results from one call to make >> another call. > > +1 on the accessor functions suggestion. I'm even considering writing my > own wrapper functions in the GUI rather than randomly poking at data > structures.
That would be a bad answer from my point of view. If you're finding need for them, others will too, so let's put them in the right layer - doesn't mean you can't write them, though that's something you and Sarah can work out. Dave
