Hi Jack,
I think this looks good, it should certainly make life more simple
for our users.
I do think checking for just dots in the service name is a little
too narrow. I was looking at the section "Restrictions on domain (DNS)
names" in RFC 3696 and believe we may instead want to check that there's
only [a-zA-Z0-9_] in the name to ensure there's not unanticipated problems
as currently it looks like I could get an ampersand or pound sign in which
could be difficult for some of the installadm shell scripts and the DNS
system too. Let me know your thoughts on this or if being C checking for
dots is about all that can easily be done at this time.
Thank you,
Clay
On Fri, 6 Mar 2009, Jack Schwartz wrote:
> Hi everyone.
>
> Here is a code review for a couple of small bugfixes:
>
> 5091 AI install does not work if your service name had . in it.
> 4610 most installadm commands need to err out gracefully if not root
>
> http://cr.opensolaris.org/~schwartz/090306.1/webrev/
>
> Please review.
>
> Thanks,
> Jack
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
