On 03/13/09 11:35, Glenn Lagasse wrote: > * Sundar Yamunachari (sundar.yamunachari at sun.com) wrote: >> Glenn Lagasse wrote: >>> All, >>> >>> I've got what I believe to be the required changes for 6699. I've >>> addressed what I believe was the intent in the bug originally. Which is >>> to say that I've removed any code and reference to installadm displaying >>> a version number. >>> >>> They are located at: >>> >>> http://cr.opensolaris.org/~glagasse/slim_6699 >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6699 >>> >>> That said, as part of some due diligence on my part I trolled around for >>> other 'version' references related to AI. I don't *think* what I've >>> found is related, but I'd like to get feedback from others who are >>> probably more familiar. >>> >>> Instances: >>> >>> usr/src/cmd/installadm/docs/manifest.html >>> 283: service name='ai_properties' version='1' type='service'> >>> >> This is official document. We will look at it when we review the >> document. These doc files will be replaced for June release. >>> usr/src/cmd/auto-install/svc/auto-installer.xml >>> 38: version='1'> >>> >> This is the version of the SMF service and it has nothing to do with >> installadm version. >>> usr/src/cmd/auto-install/ai_get_manifest.py >>> 783: <Version Number="0.5"> >>> >> This is just a comment. >>> usr/src/cmd/ai-webserver: >>> *.py files reference a version number of some sort which appears >>> different than what installadm was reporting (1.0 for installadm, 0.5 >>> for the .py files) >>> >> 0.5 appears to be the version of the module OptionParser. It has nothing >> to do with installadm version. Can you check with Clay about >> OptionParser? >>> Are any of these additional references relevant to the bug at hand? >>> They don't appear to be from my casual observation. >>> >> No. > > Thanks Sundar. So just to be clear, you're fine with the changes I've > proposed in the webrev then? > > Thanks, >
I looked at the installadm.h and installadm.c changes and they look fine (though those files have changed in the gate since this webrev was generated). I think what Sundar was saying is that you don't need to change installadm.html, because that is provided by Barbara and will be replaced for the coming release. Sue
