Clay Baenziger wrote: > Hi Sundar, since I gave Glenn the code to remove, I've tested on my > install server with list-manifest(1). > I tested removing the version string and running with no option, > -h (which provides the usage), and -c which provides the criteria for > each manifest. No difference was seen except in the case of usage. > Removing this string is only a syntax risk, otherwise, it would be a > bug in the Python base module OptionParser. > Thank you, > Clay Thanks Clay. I wanted to make sure that there is no regression.
- Sundar > > On Fri, 13 Mar 2009, Sundar Yamunachari wrote: > >> Glenn Lagasse wrote: >>> Based on some feedback and discussion with Clay, I've updated this >>> change. Could I get a complete re-review please? The changes are >>> *not* >>> significant or substantial. >>> >>> webrev: >>> >>> http://cr.opensolaris.org/~glagasse/slim_6699 >>> >>> Defect: >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6699 >>> >>> Thanks! >>> >>> >> The changes look good. I am not sure about the python file changes. >> What testing you have done for the python changes? >> >> - Sundar >>
