Sue Sohn wrote:
> Please review the changes for:
>
> 7388 create-service not reusing port number on a disabled service
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7388
>
> and
>
> 7275 /etc/netboot/wanboot.conf has wrong permissions
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7275
>
> which are posted at:
>
> http://cr.opensolaris.org/~sohn/7388_7275
>
> Thanks,
> Sue
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
usr/src/cmd/installadm/installadm_util.c
----------------------------------------------------------------
Suggestion:
386 if (access(path, F_OK) != 0) {
387 return (B_FALSE);
388 }
I would rather see the call to access be done in function
read_service_data_file()
usr/src/cmd/installadm/installadm.c
---------------------------------------------------------
Looks OK.
I did see Sanjay's comment about do_create_service() being large and
deeply nested.
I agree addressing would be good and would have made reviewing the code
easier.
Joe
