Hi Sanjay, I agree with you completely, however I do not think that restructuring do_create_service should be part of this bug fix. I would like to open a new bug to track that work, if you are ok with that.
Sue On 03/13/09 19:12, sanjay nadkarni (Laptop) wrote: > > do_create_service is a rather large function with lots of if /else > clauses. To improve readability and maintainability it would be better > to create a function called start_service. > > > -Sanjay > > > > > Sue Sohn wrote: >> Please review the changes for: >> >> 7388 create-service not reusing port number on a disabled service >> http://defect.opensolaris.org/bz/show_bug.cgi?id=7388 >> >> and >> >> 7275 /etc/netboot/wanboot.conf has wrong permissions >> http://defect.opensolaris.org/bz/show_bug.cgi?id=7275 >> >> which are posted at: >> >> http://cr.opensolaris.org/~sohn/7388_7275 >> >> Thanks, >> Sue >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
