Hi Karen.
Nice work!
A few questions/suggestions:
install_utils.py:
file_size(): what is the reasoning behind taking the actual size of
files < 1Kb, and rounding up files larger than 1Kb? Seems like
inconsistent treatment, so I'm curious. I notice that zfs directories
are shown by ls to be very small now (and not rounded to 1024 or some
other value), so the comment of 625-629 appears incorrect, since zfs
directories are not rounded up.
702: filename needs to be
root + "/" + f
Thanks,
Jack
On 03/19/09 16:20, Karen Tung wrote:
> Please review the changes for the following bugs:
>
> 4294 du isn't accurate for calculating the size of UFS-based archives
> http://defect.opensolaris.org/bz/show_bug.cgi?id=4294
>
> 7191 distro_const: errno 28, No space left on device
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7191
>
> webrev is at:
>
> http://cr.opensolaris.org/~ktung/March19/
>
> I have done the following to test my changes:
>
> 1) build images using ZFS, UFS and ZFS with compression turned on as
> build area.
> All built successfully.
>
> 2) Tested each of the images built in item 1. I booted up the image,
> and made
> sure it works in the Live CD env. Then, I installed the image, and
> made sure the installed image boots without error and works. In the
> installed
> image, I tried installing additional packages and removing packages that
> were installed from the Live CD. Also tried to use firefox.
>
> 3) Building an image using the package list used by
> the bug submitter in bug 7191. This is in progress, I don't
> expect any errors, but want to make sure there's no surprises from this.
>
> Thanks,
>
> --Karen
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
