Hi Karen.

>>
>> install_utils.py:
>>
>> file_size(): what is the reasoning behind taking the actual size of 
>> files < 1Kb, and rounding up files larger than 1Kb?  Seems like 
>> inconsistent treatment, so I'm curious.  I notice that zfs 
>> directories are shown by ls to be very small now (and not rounded to 
>> 1024 or some other value), so the comment of 625-629 appears 
>> incorrect, since zfs directories are not rounded up.
>>
> The algorithm is that for ALL file/dir sizes that's not multiples of 
> 1024, round them up so that the size can be multiples of
> 1024.  There's no distinction for large or small files.  I know sizes 
> for zfs directories are small, and so, they DO get
> rounded up to 1024 bytes, based on the algorithm.
Oops.  Yes, you're right.  I misinterpreted line 652 as div not mod.

652         if (stat.st_size % 1024 == 0):
653                 return stat.st_size

    Thanks,
    Jack


Reply via email to