Ethan,*

usr/src/lib/libict/ict.c:

*486-489 - The checking of target could be moved before line 481 -- the 
target could be null

547-559 - Does it make sense to update the file after completing both 
the tasks (changing root and user)? If first one is successful and 
second one is not successful,  we may have partially updated file.

*usr/src/lib/libict/ict_test.c:

*55, 77, 118, 123-124: Are these changes part of this bug fix?

Thanks,
Sundar

Ethan Quach wrote:
> Can I get a review for this blocker...
>
>
> Webrev:
> ------
> http://cr.opensolaris.org/~equach/webrev.4215/
>
>
> Defect:
> ------
> http://defect.opensolaris.org/bz/show_bug.cgi?id=4215
>
>
>
> Tested this fix by installing via the LiveCD and AI,
> with and without a login name specified.  All tests
> succeeded as expected.
>
>
>
> thanks,
> -ethan
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20090325/69e11013/attachment.html>

Reply via email to