Ethan, it looks good.
Jan On 03/26/09 17:29, Ethan Quach wrote: > > jan damborsky wrote: >> ict.c >> ----- >> >> 490 target, login ? login : "NULL"); >> -> >> 490 target, login != NULL ? login : "NULL"); >> >> 538 >> - according to man page for tmpnam(3C), NULL could be returned >> in case of failure. I think we should check for NULL before >> tmp_ua is used and return with failure if it is NULL. > > The webrev is udpated with these changes. > > > thanks, > -ethan
