Hi Karen,

On Fri, 3 Apr 2009, Karen Tung wrote:

> I would like to have 2 or more reviewers for the following changes.
> These changes involved changes to ICT and installadm-common.sh,
> and many DC files.
> So, perhaps somebody with expertise in those areas can take a look.
>
> 7751 AI image shows warning about /etc/system during boot
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7751
>
> 5416 GRUB shouldn't track nevada build numbers on official releases
> http://defect.opensolaris.org/bz/show_bug.cgi?id=5416
>
> webrev:
> http://cr.opensolaris.org/~ktung/April3/

Looks mostly fine, I mostly have nits.

all_lang_slim_cd_x86.xml: Not related to your changes,
do you happen to know when this essentially gets folded
into slim_cd_x86.xml and this manifest deleted from the
gate?

ict.py: line 1618: Should the error also include that the
"Grub title could not be determined"?

ict.py: line 1631: Is it Open Solaris or OpenSolaris?

Alok

Reply via email to