Hi Karen,
Karen Tung wrote:
> Hi Joe,
>
> Thank you for your code review. Please see my responses inline.
>
> The updated webrev is at: http://cr.opensolaris.org/~ktung/April6/
>
> Joseph J VLcek wrote:
>>
>> usr/src/cmd/installadm/installadm-common.sh
>> +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=
>>
>>
>>
>>
>> Issue 1:
>> --------
>>
>> 169 key=`echo $line | cut -d'=' -f1`
>> 170 if [ ${key} == ${GRUB_TITLE_KEYWORD} ] ;
>> then
>> 171 grub_title=`echo $line | cut
>> -d'=' -f2-`
>>
>> Consider using built in extended regular expression pattern matching
>>
>> if [[ "${line}" == ~(E)^${GRUB_TITLE_KEYWORD}=.* ]] ; then
>> grub_title="${line#*=}"
>>
>> See:
>> http://installzone-wiki.central.sun.com/wiki/index.php/Ksh93_Tips
>>
> That's a good idea. Changed as suggested.
If you are going to use this syntax, perhaps you should make the script a ksh
script. Right now, it is /bin/sh. I know that /bin/sh symlinks to ksh in
OpenSolaris, but it seems better to be explicit if you are using that ksh
specific syntax.
Sue
