Hi Joe, The updated webrev looks fine. However, please update 8379 with a response to the question about impact on the test teams, so that all of the info is in the bug report.
Thanks, Sue On 04/29/09 03:00, Joseph J. VLcek wrote: > Glenn Lagasse wrote: >> Hey Joe, >> >> * Joseph J. VLcek (Joseph.Vlcek at Sun.COM) wrote: >> >>> Hello Caiman-ites, >>> >>> Could I please get a code review for the changes for bug 8379. >>> >>> I have been asked to push this by COB tomorrow so, as discussed in >>> the bug meeting, I am sending the code review request prior to the >>> completion of all testing. >>> >> >> Just a couple of nits. >> >> slim_cd_x86_xml: >> >> line 192: Entries instead of entires >> >> all_lang_slim_cd_x86.xml: >> >> line 197: Entries instead of entires >> >> Otherwise looks good. >> >> Cheers, >> >> > Glenn > > webrev is updated. > > > I fixed the spelling but I did not capitalize Entries. > > all_lang_slim_cd_x86.xml > 197c197 > < entries should be: > --- > > entires should be: > > > slim_cd_x86.xml > 192c192 > < entries should be: > --- > > entires should be: > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
