Karen Tung wrote: > Hi Joe, > > Thanks for making the changes. All looks good to me. > > > --Karen > > Joseph J VLcek wrote: >> Karen Tung wrote: >>> Hi Joe, >>> >>> I think it would be good to also add another comment block >>> right before the closing </grub_menu_modifications> tag >>> to warn people about not adding any entries there. Sometimes, >>> people might not read ahead. So, I think it might be good to >>> have the warning right there too. >>> >>> Thanks, >>> >>> --Karen >>> >>> Joseph J. VLcek wrote: >>>> Hello Caiman-ites, >>>> >>>> Could I please get a code review for the changes for bug 8379. >>>> >>>> I have been asked to push this by COB tomorrow so, as discussed in >>>> the bug meeting, I am sending the code review request prior to the >>>> completion of all testing. >>>> >>>> Thanks! Joe >>>> >>>> Bug: >>>> ---- >>>> >>>> 8379 accessibility options need to be last items on GRUB menu. >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=8379 >>>> >>>> webrev: >>>> ------- >>>> http://cr.opensolaris.org/~joev/bug8379/ >>>> >>>> Note: >>>> ----- >>>> This fix only impacts the GUI installer. >>>> >>>> Description of change: >>>> ------------------------------- >>>> >>>> I have moved the SSH GRUB entry above the entires "with magnifier" >>>> and "with screen reader" and added a comment in files: >>>> >>>> usr/src/cmd/distro_const/slim_cd/all_lang_slim_cd_x86.xml >>>> usr/src/cmd/distro_const/slim_cd/slim_cd_x86.xml >>>> >>>> modules affected: >>>> ----------------- >>>> >>>> * Distro Construction (grub_setup.py) >>>> * LiveMedia Image >>>> >>>> testing done: >>>> ------------- >>>> >>>> The testing is in progress. I will not push until all testing has >>>> completed. >>>> >>>> Using DC, I am building two images, one using: >>>> usr/src/cmd/distro_const/slim_cd/all_lang_slim_cd_x86.xml >>>> and the other using: usr/src/cmd/distro_const/slim_cd/slim_cd_x86.xml >>>> >>>> I will booted the live image using Virtual Box and confirm: >>>> - A new "ssh enabled" GRUB entry is available above "with magnifier" >>>> and "with screen reader >>>> - ssh is enabled on the live desktop >>>> - the default language settings are made. >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> >> >> Karen, >> >> Good idea. I will add more comments after the "with magnifier" and >> "with screen reader". >> >> All my testing is done and the webrev has been updated. >> >> Please confirm it looks OK to push. >> >> Thanks, Joe >
Thank you Karen, Glenn & Sue for the review input. Pushing. Joe
