>
>> 1872-1876 - Should we use a static flag in this function so that the
>> env is only checked once?
>
> I wanted to be able to turn it on and off at any point even if the
> library were in the middle of processing. By checking the env every
> time we call be_print_err() we can turn this on and off at will.
D'oh we can't do this anyway because once the process starts changing the env
of
the user doesn't affect the env of the process. (so never mind...)
I've implemented the static flag so ignore the comment below.
>
>> Or at a minimum, this chunk could be moved to be an else clause at 1882.
>
> Do you mean instead of setting the do_print flag to true?
>
> maybe something like this?
>
> va_start(ap, prnt_str);
> if (do_print) {
> (void) vsprintf(buf, prnt_str, ap);
> (void) fprintf(stderr, buf);
> } else if ((env_buf = getenv("BE_PRINT_ERR")) != NULL) {
> if (strcasecmp(env_buf, "true") == 0) {
> (void) vsprintf(buf, prnt_str, ap);
> (void) fprintf(stderr, buf);
> }
> }
>
>
>
>
