Dave Miner wrote: > Evan Layton wrote: >> This fix adds the use of error codes throughout libbe. All functions >> should now return the errors codes defined in libbe.h. >> >> I've also added the use of an environment variable (BE_PRINT_ERR) that >> enables printing the error output in the library without having to >> compile in changes to enable this printing. >> > > It's not clear to me why we want to retain this printing. What's the > motivation for not just removing them? > > Dave
I'm not sure I understand what you mean, why wouldn't we want to have the ability to print out error messages? What this refers to is the printing of error messages from the library functions. We want to keep these so that if needed we can get more information on what errors may have occurred than can be passed back as an error code. Also with the ZFS errors there is no way provided in libzfs to get an error code but only though a call to get the description of the error just after it happens. We need to be able to print these out so we know what ZFS error occurred. -evan
