Hi Jan.
Codewise, changes look fine, but having "CLI cmd" as the message prefix
seems to miss the mark to me.
If discussion on the prefix occurred and I missed it, then disregard the
following comments...
Neither the bug report nor the caiman-discuss thread mentioned "CLI" and
I don't think "CLI" adds any value. I think a prefix of "command:" or
maybe "exec command" would be easier for someone to understand.
Thanks,
Jack
On 12/04/09 05:10, Jan Damborsky wrote:
> Hi Karen,
>
> could I please ask you to review easy fix
> for following bug ?
>
> 12853 'pkg cmd:' prefix emitted by
> install_utils.exec_cmd_outputs_to_log() is confusing in DC log
>
> Please ignore following message in log files generated by pkg(1)
> (I verified the issue has been addressed in latest pkg):
> ...
> /usr/lib/python2.6/vendor-packages/pkg/manifest.py:32:
> DeprecationWarning: the sha module is deprecated; use the hashlib
> module instead
> import sha
> ...
>
> Thank you very much,
> Jan
>
>
> * Webrev
> http://cr.opensolaris.org/~dambi/bug-12853/
>
> * Modules affected
> - install_utils.py
>
> * Testing done
> - DC build done with modified install_utils.py
> - AI installation done with modified install_utils.py
>
> * DC & AI log files
> http://cr.opensolaris.org/~dambi/bugs-12853-logs/
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
