Hi Jan.
Thanks for making the change. Looks fine now!
Thanks,
Jack
On 12/06/09 23:46, Jan Damborsky wrote:
> Hi Jack,
>
>
> Jack Schwartz wrote:
>> Hi Jan.
>>
>> Codewise, changes look fine, but having "CLI cmd" as the message
>> prefix seems to miss the mark to me.
>
> This is valid point.
>
>>
>> If discussion on the prefix occurred and I missed it, then disregard
>> the following comments...
>
> The discussion about prefix format didn't happen,
> it was assumed this could be sorted out during code
> review :-)
>
>>
>> Neither the bug report nor the caiman-discuss thread mentioned "CLI"
>> and I don't think "CLI" adds any value. I think a prefix of
>> "command:" or maybe "exec command" would be easier for someone to
>> understand.
>
> I like the latter one :-)
>
> The webrev has been updated accordingly.
>
> Thank you very much for review,
> Jan
>
