Hi Sarah, Sarah Jelinek wrote: > Hi jan, > > Jan Damborsky wrote: >> Hi Sarah, >> >> the changes look good to me (modulo Mike's comments). >> >> I have only question about transfermod.h header file - >> looking at the slim gate, two exist for now: >> >> [1] usr/src/lib/liborchestrator/transfermod.h >> [2] usr/src/lib/libtransfer/transfermod.h >> >> Looking at the differences, [2] misses some necessary >> definitions (nvlist attributes). Do you think it might be >> appropriate orchestrator switches to [2] after it is enriched >> by required definitions ? >> If you agree, I could follow up on this with Moinak >> in order to solve this. >> > I think we should only use 1 transfermod.h. I didn't realize there were > 2. Please file a bug on this and one of us can clean it up. Thanks for > catching this.
Done - I have just filed http://defect.opensolaris.org/bz/show_bug.cgi?id=708 I will follow up on this in order to clean it up. > > Thanks for the review. You are welcome ! Jan > > sarah > **** >> Thank you, >> Jan >> >> >> Sarah Jelinek wrote: >>> Hi Sundar and Jan, >>> >>> Can you please review the changes for: >>> >>> Bug 135 .bashrc owned by root >>> >>> >>> webrev located: >>> >>> >>> http://cr.opensolaris.org/~sjelinek/bashrc_bug/ >>> >>> I also did some nits cleanup in the other files. >>> >>> Thanks, >>> sarah >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
