Virginia Wray wrote:
> Hi -
>
> This bug isn't quite as extensive as it looks on the webrev. The purpose 
> of the bug was to remove the inst subdirectory and move everything 
> within that directory up one level under the cmd directory. The result 
> is cmd/gui-install/.... instead of cmd/inst/gui-install/.... All of the 
> files in the SUNWinstall package structure and in the proto area for 
> this directory is unchanged.  I also took the opportunity to remove the 
> keywords for these files.
>
> There is one file, gui-install/src/installationdisk.glade, that doesn't 
> have any CDDL text? Should that be added?
>   
It looks like it should be to me. I'm not an expert in that area so you 
might try
asking someone who is. I believe Moriah has dealt in this a bit. Or go 
to Bonnie Corwin.
> Bug Id: 711 - http://defect.opensolaris.org/bz/show_bug.cgi?id=711
>
> Webrev:http://cr.opensolaris.org/~ginnie/711/
>
> thx,
>
>   
Looked good to me. You're right, there really wasn't much there to review.

Jean


Reply via email to