Hi  Dave-
I've incorporated the changes that you suggested to 
usr/src/cmd/Makefile.master and added the CDDL text to 
installationdisk.glade.

Webrev is located at: http://cr.opensolaris.org/~ginnie/711/

 If you could take a quick look, I would appreciate it.
thx,
ginnie



Dave Miner wrote:
> Virginia Wray wrote:
>> Hi -
>>
>> This bug isn't quite as extensive as it looks on the webrev. The 
>> purpose of the bug was to remove the inst subdirectory and move 
>> everything within that directory up one level under the cmd 
>> directory. The result is cmd/gui-install/.... instead of 
>> cmd/inst/gui-install/.... All of the files in the SUNWinstall package 
>> structure and in the proto area for this directory is unchanged.  I 
>> also took the opportunity to remove the keywords for these files.
>>
>> There is one file, gui-install/src/installationdisk.glade, that 
>> doesn't have any CDDL text? Should that be added?
>>
>> Bug Id: 711 - http://defect.opensolaris.org/bz/show_bug.cgi?id=711
>>
>> Webrev:http://cr.opensolaris.org/~ginnie/711/
>>
>
> usr/src/cmd/Makefile.master,
>
> 38-40, 59, etc: why add these definitions if we have no use for them?
>
> 47: seems like cstyle and lintlib should be here, too
>
> 63: why can't gui-install just be part of the SUBDIRS definition on 34?
>
> Dave


Reply via email to