Hi,

Requesting code review for bug 826 : Theme switching in installer GUI is broken
http://defect.opensolaris.org/bz/show_bug.cgi?id=826

Webrev is available at:
http://cr.opensolaris.org/~niall/bug-826-a/

The approach to fix this is to factor out the some of the button creation code 
into
2 new functions, one to create the necessary image, and the other to insert it
into the button.
When the icon theme changes, the images for the buttons get regenerated and
reset inside each existing button.
I also adjusted the spacing between buttons from 35 to 36 pixels for consistency
with the GNOME HIG each stipulates spacings in multiples of 6 pixels.


Thanks,
Niall.
--
This message posted from opensolaris.org

Reply via email to