Thanks Jedy.
Jedy Wang wrote:
> Hi Niall,
>
> The patch looks fine to me.
>
> Regards,
>
> Jedy
> On Thu, 2008-03-20 at 02:32 -0700, Niall Power wrote:
>> Hi,
>>
>> Requesting code review for bug 826 : Theme switching in installer GUI is
>> broken
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=826
>>
>> Webrev is available at:
>> http://cr.opensolaris.org/~niall/bug-826-a/
>> <http://cr.opensolaris.org/%7Eniall/bug-826-a/>
>>
>> The approach to fix this is to factor out the some of the button creation
>> code into
>> 2 new functions, one to create the necessary image, and the other to insert
>> it
>> into the button.
>> When the icon theme changes, the images for the buttons get regenerated and
>> reset inside each existing button.
>> I also adjusted the spacing between buttons from 35 to 36 pixels for
>> consistency
>> with the GNOME HIG each stipulates spacings in multiples of 6 pixels.
>>
>>
>> Thanks,
>> Niall.
>> --
>> This message posted from opensolaris.org
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org <mailto:caiman-discuss at opensolaris.org>
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
