Hi all, Jean asks why did I remove the line 125 stuff. I know I didn't make any changes in verify_conf(), but I did have mercurial sync issues. I ran hg update / hg merge commands and they said they succeeded, but I know that Dave Miner's changes in build_dist.lib for bug 832 got lost. I added that block of code in manually, but it looks like a different change got lost.
I will put that block back in and regenerate the webrev. As for lines 208, 216, 223... Jean is correct that this is code that used to live in livemedia processing. I will review the code to make sure fata_micro_exit is still relevant here as MICROROOT2 is no longer in use. Channing Jean McCormack wrote: > Channing Lovely wrote: >> Please review >> >> http://cr.opensolaris.org/~lovely/microroot/ >> >> which addresses >> >> 835 DC microroot creation should be cleaner >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=835 >> >> Thanks, >> >> Channing >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > build_dist.lib > > line 125: Why did you remove this? > > line 208,216,223: I don't think fatal_micro_exit is what you want here > since it umounts > $MICROROOT2 = $DIST_PROTO/bootcd_microroot2 and lofiadm -d 's > $BOOT_ARCHIVE2 = /$DIST_PROTO/boot/x86.microroot2 > I suspect you really want it to do this to TMP_ARCHIVE? > > Question: Is some of the code that used to be in livemedia processing > that has now been moved to finalize_root_archive really for > livemedia? Or is it needed for the root_archive? There's a subtle > difference and I just want to make sure the differentiation has been > maintained. > Or maybe the differentiation was incorrect in the first version? > > > Jean > > > > >
