Hi Channing,
Here's my look over:
*I agree with Sanjay: Lines 155-168: should have absolute paths.
However, then things like cat and grep, find, rm, mv, etc. need
to be defined. How about setting absolute paths as variables, and
a sane path to begin with
*line 167: it would be interesting to use 7-zip's gzip since
it seems more efficient on space. (Not within your project's
scope though.)
*line 188,226: do you need to track the directory and change back
to it?
*lines 237-269: could this be put more cleanly into a for loop?
for dir in kernel platform system lib sbin dev devices opt
root jack; do
/usr/bin/find ./$dir | /usr/bin/cpio -pdum $MICROROOT
done
This way it's more obvious that boot is special and has the
grep -v bit
*line 290-292: the grep directory strings would be much easier to
find on if they were not escaped (I don't believe they need to
be for grep)
------- I think this is old code below which you simply moved in -----------
*line 372-374: can't these three lines be cleanly combined?
*line 373: again, please don't escape (unless I'm missing
something)
Also there was a directory you said was non-obvious that needed to exist
or the installer would hang at 13% did you comment about that anywhere?
Thank you,
Clay
On Fri, 21 Mar 2008, Channing Lovely wrote:
> Please review
>
> http://cr.opensolaris.org/~lovely/microroot/
>
> which addresses
>
> 835 DC microroot creation should be cleaner
>
> http://defect.opensolaris.org/bz/show_bug.cgi?id=835
>
> Thanks,
>
> Channing
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
