Hi Karen! On Mon, 2009-10-05 at 12:48 -0700, Karen Tung wrote: > Hi Alexandar, > > Thanks for making the changes. You are right about the fact that the > first CPIO that's done in the existing bootroot_archive.py script is a bug. > > Here are my comments the changes: > > - line 103: shouldn't the check be done for dst + "/" + cpio_file? This line not recognize symlinks in /dev > - Please add more detail to the comment on lines 327-329 explaining > why different overhead multipliers are used for sparc. > - I think it would make the code easier to read if you move the code > between lines 370-415 around so there's only 1 if-then-else block for > if (sparc)... else... > - You didn't mention it in your message above. Did you also built > and tested x86 LiveCD images to make sure the changes didn't affect > those? Done > - I noticed that the formatting of the file doesn't correspond to the new > PEP8 formating requirement that Clay sent email about last week. > Can you fix that? The link announcing the requirement is at: > http://www.opensolaris.org/jive/thread.jspa?threadID=114047&tstart=15 Formatted > Thank you for your work! > > --Karen Tests for x86 is ok. webrev is updated: http://cr.opensolaris.org/~alhazred/6361/
-- ::alhazred
