Hi Alexander, Please see my comments inline.
Alexander Eremin wrote: > Hi Karen! > On Mon, 2009-10-05 at 12:48 -0700, Karen Tung wrote: > >> Hi Alexandar, >> >> Thanks for making the changes. You are right about the fact that the >> first CPIO that's done in the existing bootroot_archive.py script is a bug. >> >> Here are my comments the changes: >> >> - line 103: shouldn't the check be done for dst + "/" + cpio_file? >> > This line not recognize symlinks in /dev > The symlinks in /dev doesn't get recognized because the actual file those links point to don't exist yet. You can use os.path.lexists(), which will only verify the symlink exists, but it won't try to follow the link. > >> - I noticed that the formatting of the file doesn't correspond to the new >> PEP8 formating requirement that Clay sent email about last week. >> Can you fix that? The link announcing the requirement is at: >> http://www.opensolaris.org/jive/thread.jspa?threadID=114047&tstart=15 >> > Formatted > How did you format the file? It still doesn't look like it fits the PEP8 requirements. One simple thing I noticed is that fact that PEP8 require blocks to be indented by 4 spaces, and lines to be 80 chars or less. I noticed the file still have those problems. As suggested in Clay's email, Netbeans with the python plugin can help to format the file to the appropriate style easily. Thank you. --Karen
