Hi Jack,
Thank you for the suggestion of the comment. Since I'd not
remembered I certainly agree that a comment was need. One is in the final
version.
Thank you
, Clay
On Thu, 8 Oct 2009, Jack Schwartz wrote:
> Hi Clay.
>
> On 10/08/09 16:17, Clay Baenziger wrote:
>> Hi Jack and all,
>> Just a follow-up:
>> I had noticed something changed between my initial version of the code
>> and after all the code review changes.
>>
>> Unfortunately, using a SIGTERM causes all dns-sd and ai-webserver
>> processes to get killed off (and SIGINT fails to kill them). As such, I'm
>> again using SIGKILL, as it seems to be the only way to kill off the AI
>> webserver and dns-sd without killing them all. Apache is killed from SMF
>> transitioning to maintenance, so it's not affected by using SIGKILL.
> OK. Please add a comment about why SIGKILL is needed in the code, to prevent
> people like me from asking about it in the future.
>
> Thanks,
> Jack
>>
>> Thank you,
>> Clay
>>
>> On Tue, 8 Sep 2009, Jack Schwartz wrote:
>>
>>> Hi Clay.
>>>
>>> Here are my comments.
>> [snip...]
>>> /usr/src/cmd/installadm/delete-service.py
>>> -----------------------------------------
>> [snip...]
>>> 629, 659: as discussed, SIGKILL may be too abrupt. A milder signal like
>>> SIGTERM
>>> or maybe SIGINT would be better as it would allow cleanup.
>> [snip...]
>>
>
>
