Clay Baenziger wrote: > Hi Evan, > Thank you for reviewing this! Some comments in-line, anything you > sent not mentioned below, I'll be fixing. > Thank you, > Clay > > On Wed, 9 Sep 2009, Evan Layton wrote: > >> installadm.c >> ----------------- >> lines 898 - This comment needs a bit more clarification. Maybe >> something like: >> 898 * If the -x argument is passed, it will remove the image. >> 899 * Other cleanup is handled and done in the SERVICE_DELETE_SCRIPT > > This comment was largely as was there before I started. I'm not fond of > it though as option parsing is handled elsewhere and the -x is not > really evident anywhere near there. How about just saying all clean-up > is handled in the SERVICE_DELETE_SCRIPT?
I think that's OK but we may want to remove the reference to the -x option and just say "ll clean-up is handled in the SERVICE_DELETE_SCRIPT, including removal if the image if speficed" or something like that. Keep in mind that this is really just a nit and what you've suggested is probably OK... > >> libaiscf_instance.c: >> Should we be calling "ai_scf_fini(self->scfHandle);" before lines >> 210 and 229? > > Good catch, however, I think only at 229 as the handle will be NULL at 210? Sounds good. -evan
