Joseph J VLcek wrote:
> Evan Layton wrote:
>> I need to get reviews for the following bugs that are causing failures
>> if the directories where the boot/grub menu files live are missing
>> (/rpool/boot and /rpool/boot/grub). Also this fix resolves the issue
>> with the add_splash_image_to_grub_menu that was causing a failure to
>> create a menu.lst file when it's missing.
>>
>>
>> The bugs:
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7880
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=11436
>>
>>
>> The webrev:
>> http://cr.opensolaris.org/~evanl/7880/
>>
>>
>> Thanks,
>> -evan
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
> ict.py
>
> Issue:
> ------
>
> 305 order to protect against accidental usage durring
Fixed
>
> durring -> during
>
> Issue:
> ------
>
> 312
> nit: unnecessary blank line
>
Fixed
> Issue:
> ------
>
> 333 if ((self.LIVECD_INSTALL) or (self.AUTO_INSTALL)):
> 334 self.BOOTENVRC = BASEDIR + BOOTENVRC #/boot/solaris/bootenv.rc
> 335 else:
> 336 self.BOOTENVRC = BOOTENVRC #/boot/solaris/bootenv.rc
>
> Please add a comment describing the condition where this code is required.
Removed the comments at the end of these lines ad added a block comment before
this section of code:
'''
If we're running outside of an install we should not use
the basdir here since that could be the mounpoint of a
pool that we're creating the menu.lst file on.
'''
I've updated the code and posted an updated webrev at:
http://cr.opensolaris.org/~evanl/7880v2/
Thanks everyone for the comments!
-evan
