On 10/09/09 00:47, Evan Layton wrote:
> I need to get reviews for the following bugs that are causing failures
> if the directories where the boot/grub menu files live are missing
> (/rpool/boot and /rpool/boot/grub). Also this fix resolves the issue
> with the add_splash_image_to_grub_menu that was causing a failure to
> create a menu.lst file when it's missing.
>
>
> The bugs:
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7880
> http://defect.opensolaris.org/bz/show_bug.cgi?id=11436
>
>
> The webrev:
> http://cr.opensolaris.org/~evanl/7880/
>
>
> Thanks,
> -evan
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Evan,
Here are my comments:
usr/src/lib/libbe/tbeadm/Makefile
Needs updated copyright
usr/src/lib/libbe/be_utils.c
3445,3457-3461 Why is temp_str needed here? It doesn't look like it is used.
I also think you can remove the else clause altogether
3469-3470 - There is a %s for the dirname, but no dirname.
usr/src/lib/libict_pymod/ict.py
305 - durring->during
329 - maybe append "during install" to error msg?
319 - this comment should be back down at 360.
334,336 Shouldn't the comment be different for these two lines?
360 - The code associated with this comment was moved up, so the comment
should also be moved up. Maybe you moved the wrong comment (319) up
by accident.
882 - You don't really need the backslash, python will know to continue
inside a paren
Thanks,
Sue
