Hi Jean, I have a couple of comments/questions. Everything else look good to me.
- In a few places, you have "disable-msg=xxxxxxx". Would it be possible to put a comment specifying what that message id refers to. That way, the person reading the code don't need to go and look it up. - DefaultsModule.py, line 94: this function name starts with an "_". It's kinda odd. I know "__" is for private functions for a class. Not sure whether "_" means anything. Do you think it might be OK to change it so we don't have the "_"? Thanks, --Karen jeanm wrote: > Here's the code review for my Python2.4->2.6 and pylint changes for DC. > > http://cr.opensolaris.org/~jeanm/slim_2.6/ > > Can I ask Karen to look at this, along with anyone else who wants to, > since she's familiar with the DC. > > Jean > > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
