Keith Mitchell wrote:
>
>
> jeanm wrote:
>>>
>>> - DefaultsModule.py, line 94:
>>> this function name starts with an "_".  It's kinda odd.
>>> I know "__" is for private functions for a class.  Not sure whether
>>> "_" means anything.  Do you think it might be OK to change it so
>>> we don't have the "_"?
>> The second _ was removed by mistake. I'll put it back to __ since it 
>> is private.
>>
>> Thanks for the review.
>
> For future reference, from PEP-8:
>
>    Method Names and Instance Variables
>
>      ...
>
>      Use one leading underscore only for non-public methods and instance
>      variables.
>
>      To avoid name clashes with subclasses, use two leading 
> underscores to
>      invoke Python's name mangling rules.
>
>
Since the _UID() function is supposed to be private, the way Jean had before
is correct then.

Thanks Keith.

--Karen

Reply via email to