Hi Jan.
Here are my comments:
ti_dm.c:
284: Seems to me that nsecs is best defined as a diskaddr_t instead of a
uint32_t. On line 315, other variables such as sector_min, are
diskaddr_t, and conceivably nsecs, the number of sectors, can be above
sector_min. Also, if the def of a diskaddr_t changes in the future,
there won't be a maintainability issue here.
I looked and diskaddr_t is a u_longlong_t (in uts/common/sys/types.h
a.k.a. /usr/include/sys/types.h)
This also means changing the declaration of nsecs on 1477.
345, 362, 379: "i" is still an int. The first format specifier here
should be %d
ti_dm.h: good eye!
The rest looks fine to me.
Thanks,
Jack
On 07/07/09 08:42, Jan Damborsky wrote:
> Hi,
>
> could I please ask for reviewing simple change for following bug ?
>
> 9026 vtoc partition size is not cylinder size adjusted on disk bigger
> than 1.96TB
>
> webrev:
> http://cr.opensolaris.org/~dambi/bug-9026
>
> While I was there, I have also fixed following issues:
>
> * error message in ti_zfm.c (thanks Greg Onufer for catching this).
> It had ZFS volume name and pool name swapped around.
>
> * typo in idm_cyls_to_mbs macro definition in ti_dm.h
>
> Thank you very much,
> Jan
>
>
> modules affected:
> -----------------
> * libti
>
>
> testing done
> ------------
>
> [1] LiveCD - test of fix
> ----------------------------
> * HW: - Ultra 20 (1GB RWM)
> - target disk: external USB 4TB
>
> * SW: - created LiveCD ISO based on build 117 (contains fix for
> 6843138 GRUB issue)
> with modified libti
>
> * result:
> - installation succeeded (no adjustments done by TI to created VTOC)
> - system booted to desktop
> - format correctly recognized created VTOC
>
> [2] SPARC AI - regression test
> ------------------------------
> * HW: - sun4v T1000 (2GB RWM - LDOM control domain)
> - target disk: 73GB
>
> * SW: AI image based on build 117 with modified libti
>
> * result:
> - installation succeeded (no adjustments done by TI to created VTOC)
> - system booted
> - format correctly recognized created VTOC
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
