Hi Ethan, thank you very much for review. Please see my response below.
Jan Ethan Quach wrote: > Jan, > > The changes look fine. > > > Jan Damborsky wrote: >> Hi, >> >> could I please ask for reviewing simple change for following bug ? >> >> 9026 vtoc partition size is not cylinder size adjusted on disk bigger >> than 1.96TB >> >> webrev: >> http://cr.opensolaris.org/~dambi/bug-9026 >> >> While I was there, I have also fixed following issues: >> >> * error message in ti_zfm.c (thanks Greg Onufer for catching this). >> It had ZFS volume name and pool name swapped around. >> >> * typo in idm_cyls_to_mbs macro definition in ti_dm.h > > Are there any known bugs this would have caused? The typo actually didn't cause any issue, as idm_cyls_mbs macro is currently used only in idm_calc_swap_size() function and misspelled macro parameter was the same as variable passed to the macro, so the code worked correctly and compiler didn't complain either. > > > thanks, > -ethan > >> >> Thank you very much, >> Jan >> >> >> modules affected: >> ----------------- >> * libti >> >> >> testing done >> ------------ >> >> [1] LiveCD - test of fix >> ---------------------------- >> * HW: - Ultra 20 (1GB RWM) >> - target disk: external USB 4TB >> >> * SW: - created LiveCD ISO based on build 117 (contains fix for >> 6843138 GRUB issue) >> with modified libti >> >> * result: >> - installation succeeded (no adjustments done by TI to created VTOC) >> - system booted to desktop >> - format correctly recognized created VTOC >> >> [2] SPARC AI - regression test >> ------------------------------ >> * HW: - sun4v T1000 (2GB RWM - LDOM control domain) >> - target disk: 73GB >> >> * SW: AI image based on build 117 with modified libti >> >> * result: >> - installation succeeded (no adjustments done by TI to created VTOC) >> - system booted >> - format correctly recognized created VTOC >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
