Masafumi, Regarding your code diffs in perform_slim_install.c, 2336.
1) Adding this code here stomps over the cmd string that was generated right before this chunk of code. In other words, "zpool set bootfs=...." doesn't get run now. You probably weren't intending that. You'd really want to do add another call to to_safe_system(cmd, B_TRUE) so that both commands get executed. However, see (2)... 2) activate_be() is called after the bits have been transferred over to the installed system, so turning on compression at this point doesn't do you any good. In other words, the installed system isn't installed with compressed content. What you want to do is to make compression be turned on right when the pool is created. To do this, you'll need to make some modifications to libti (probably somewhere in zfm_create_pool() so that it takes additional arbitrary pool attributes, and then where ever liborchestrator prepares the pool attributes passed to libti.) [sorry for the laggy gaps in response, we were in meetings all last week and didn't have a whole lot of time responding to mail.] thanks, -ethan Masafumi Ohta wrote: > Ethan, > > I now have uploaded 3 files about webrev: > > slim_source.pdf 22-Jul-2009 02:24 15K > slim_source.ps 22-Jul-2009 02:24 34K > webrev.zip 22-Jul-2009 02:23 224 > > -masafumi > > > On 09.7.22 1:31 AM, Masafumi Ohta wrote: >> Ethan, >> >> really sorry I misunderstood "webrev" >> I will upload again with using webrev so soon. >> >> Thanks, >> >> -masafumi >> >> On 09.7.20 6:42 PM, Masafumi Ohta wrote: >>> Ethan, >>> >>> okay got that. >>> I tried to attach the files but it is over the size (40KB)? >>> so I re-uploaded perform_slim_install.c and slim_cd_x86_3.xml >>> >>> *perform_slim_install.c >>> I pointed out 2330th line later about my changes in the file as >>> follows,that is, >>> >>> /* >>> * Set zfs compression for root pool. >>> * (I changed as follows) >>> */ >>> >>> >>> (void) snprintf(cmd, sizeof (cmd), >>> "/usr/sbin/zfs set compression=on $s/ROOT/$s", >>> ROOTPOOL_NAME, be_name); >>> >>> *slim_cd_x86_3.xml >>> >>> I changed two points:'post_install_remove_packages' and 'finalizer' >>> >>> I pointed out 241st line later about my changes as follows for >>> ''post_install_remove_packages' >>> (for removing old installer packages) >>> >>> == >>> <!-- SUNWinstaller Change for replacing installer1 --> >>> <pkg name="SUNWgui-install"/> >>> <pkg name="SUNWinstall"/> >>> == >>> >>> and point out 408th line later about my changes as follows for >>> "finalizer" >>> (for installing new installer packages for zfs compression) >>> >>> == >>> <!-- replacing new installer for zfs compression--> >>> <script name="/root/manufest/SUNWgui_install_install"> >>> <checkpoint >>> name="SUNWgui-install" >>> >>> message="SUNWgui-install installation"/> >>> </script> >>> <script name="/root/manufest/SUNWinstall_install"> >>> <checkpoint >>> name="SUNWinstall" >>> message="SUNWinstall >>> installation"/> >>> </script> >>> <script name="/root/manufest/SUNWinstall-lib_install"> >>> <checkpoint >>> name="SUNWinstall-libs" >>> message="SUNWinstall >>> installation"/> >>> </script> >>> == >>> >>> for more detail I much appreciate if you could check these files >>> downloading. >>> >>> Thanks a lot, >>> -masafumi >>> >>> On 09.7.20 4:08 PM, Ethan Quach wrote: >>>> Masafumi, >>>> >>>> Attaching or pointing us to a webrev of your changes might be helpful. >>>> >>>> -ethan >>>> >>>> >>>> Masafumi Ohta wrote: >>>>> Hi Shawn >>>>> >>>>> I had omit 'entire' as said so I correct >>>>> but I failed again installer doesn't work and dump the core.. >>>>> >>>>> I filed something log and related files on the site: >>>>> http://kohju.justplayer.com/docs/mirror/OpenSolaris/eeepc-special/work/ >>>>> >>>>> >>>>> first time I added >>>>> /slim_0906/usr/src/lib/liborchestrator/perform_slim_install.c >>>>> and added as follows (see the 'perform_slim_install.c'on the site) >>>>> >>>>> (void) snprintf(cmd, sizeof (cmd), >>>>> "/usr/sbin/zfs set compression=on $s/ROOT/$s", >>>>> ROOTPOOL_NAME, be_name) >>>>> >>>>> >>>>> and build and succeeded (see the log files on the site). >>>>> and distro_const with 'slim_cd_x86_3.xml to >>>>> replace SUNWgui-install,SUNWinstall,SUNWinstall-libs for oldies. >>>>> it succeeded to build LiveUSB and tried to use on my Eee 901. >>>>> >>>>> when I use 'pfexec gui-install',it doesn't work and says >>>>> 'Segmentation Fault(core dumped)'.. >>>>> I checked the cores,gui-install seemed to be failed by >>>>> liborchestrator.. >>>>> >>>>> So I tried not to change any source files(but I only changed >>>>> developer.sh to use SunStudioexpress) >>>>> and did the same way but I met same -doesn't work and dump core... >>>>> >>>>> I would be much appreciate if you could check it and give me some >>>>> ideas.. >>>>> >>>>> Thanks a lots, >>>>> (And give some ideas to Alex(in facebook) and ClayB(in IRC in >>>>> Caiman)) >>>>> >>>>> -masafumi >>>>> >>>>> On 09.7.13 2:55 PM, Shawn Walker wrote: >>>>>> Masafumi Ohta wrote: >>>>>>> Hello, >>>>>>> >>>>>>> I would love to add 'zfs set compression=on >>>>>>> /rpool/ROOT/opensolaris' to OpenSolaris installer. >>>>>>> So lately I've been reading caiman slim_source for adding zfs >>>>>>> set compression=on,because >>>>>>> lately increasing OpenSolaris specs makes would take bigger disks >>>>>>> >>>>>>> I now decreasing OpenSolaris packages deleting non-useful >>>>>>> packages for netbooks. >>>>>>> .but I am afraid I might not catch up with that 'bigger' size >>>>>>> OpenSolaris latest has. >>>>>> >>>>>> Just be certain that 'entire' is not one of the packages you omit. >>>>>> >>>>>> Otherwise, the installed system won't work properly with the >>>>>> package management system (because packages won't be properly >>>>>> constrained to a specific build). >>>>>> >>>>>> Cheers, >>>>> >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> caiman-discuss at opensolaris.org >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> >
