libbe/Makefile: copyright date is still 2008 be_activate: line 736: I believe you need to close zhp here. line 862: I think you need to close zphp here. line 875: ditto Shouldn't lines 903-4 be after the done with a check for null? Otherwise line 892 path doesn't close cap_fp
be_create: copyright date is 2008 be_list: line 311: I believe this should be a close of rpool_zhp be_mount: copyright date is 2008 line 1019: Do you need to free orig_mntpt? be_util: line 349: Don't you need to free pool_mntpt? line 1066: ditto line 1211: ditto line 1416: ditto line 1683: ditto (rpool_mntpt) line 1455: fclose(menu_fp)? libbe_pymod/Makefile: copyright date is 2008 Jean Evan Layton wrote: > I need to get a code review for the following fixes. > > webrev: > ------------ > http://cr.opensolaris.org/~evanl/9594 > > > Bugids: > ----------- > http://defect.opensolaris.org/bz/show_bug.cgi?id=8638 > http://defect.opensolaris.org/bz/show_bug.cgi?id=9051 > http://defect.opensolaris.org/bz/show_bug.cgi?id=9594 > > Some back ground: > The main bug is 9594 which was an oversight in the original design > where we did not take into account the possibility that the root > pool dataset (/rpool) was not mounted. To fix this we attempt to > mount it at it's normal mount point, if that mount fails we attempt > to mount it on a temporary mount point. > > We also discovered we were erroneously checking for error conditions > from libzfs property checking functions such as zfs_prop_get_int(). > These functions are expected to allows succeed and do not set the > libzfs error codes. The incorrect error checking was also fixed as > part of this fix. > > > Thanks, > -evan > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
